dorian
/
paramiko
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[project @ robey@lag.net-20061215211936-rgc3uzy5ai9h6qho] 

bug 75370: notice garbage sftp packets
since sftp packets shouldn't be larger than about 32k, if the first length
byte is non-zero (ie, the packet size > 16M), raise an exception.
This commit is contained in:
Robey Pointer 2006-12-15 13:19:36 -08:00
parent 76285309cf
commit 7058f5ead2
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
paramiko/sftp.py
View File

@ -176,7 +176,12 @@ class BaseSFTP (object):
self._write_all(out) self._write_all(out)
def _read_packet(self): def _read_packet(self):
size = struct.unpack('>I', self._read_all(4))[0] x = self._read_all(4)
# most sftp servers won't accept packets larger than about 32k, so
# anything with the high byte set (> 16MB) is just garbage.
if x[0] != '\x00':
raise SFTPError('Garbage packet received')
size = struct.unpack('>I', x)[0]
data = self._read_all(size) data = self._read_all(size)
if self.ultra_debug: if self.ultra_debug:
self._log(DEBUG, util.format_binary(data, 'IN: ')); self._log(DEBUG, util.format_binary(data, 'IN: '));