Refactoring: it's a thing. Re #85

tests/test_buffered_pipe.py

@@ -26,6 +26,8 @@ import unittest
 from paramiko.buffered_pipe import BufferedPipe, PipeTimeout
 from paramiko import pipe
 
+from util import ParamikoTest
+
 
 def delay_thread(pipe):
     pipe.feed('a')
@@ -39,11 +41,7 @@ def close_thread(pipe):
     pipe.close()
 
 
-class BufferedPipeTest (unittest.TestCase):
+class BufferedPipeTest(ParamikoTest):
-
-    assertTrue = unittest.TestCase.failUnless   # for Python 2.3 and below
-    assertFalse = unittest.TestCase.failIf      # for Python 2.3 and below
-
     def test_1_buffered_pipe(self):
         p = BufferedPipe()
         self.assert_(not p.read_ready())

tests/test_transport.py

@@ -36,6 +36,7 @@ from paramiko import OPEN_SUCCEEDED, OPEN_FAILED_ADMINISTRATIVELY_PROHIBITED
 from paramiko.common import MSG_KEXINIT, MSG_CHANNEL_WINDOW_ADJUST
 from paramiko.message import Message
 from loop import LoopSocket
+from util import ParamikoTest
 
 
 LONG_BANNER = """\
@@ -105,13 +106,7 @@ class NullServer (ServerInterface):
         return OPEN_SUCCEEDED
 
 
-class TransportTest (unittest.TestCase):
+class TransportTest(ParamikoTest):
-
-    if not hasattr(unittest.TestCase, 'assertTrue'):
-        assertTrue = unittest.TestCase.failUnless   # for Python 2.3 and below
-    if not hasattr(unittest.TestCase, 'assertFalse'):
-        assertFalse = unittest.TestCase.failIf      # for Python 2.3 and below
-
     def setUp(self):
         self.socks = LoopSocket()
         self.sockc = LoopSocket()

tests/test_util.py

@@ -28,6 +28,7 @@ import unittest
 from Crypto.Hash import SHA
 import paramiko.util
 
+from util import ParamikoTest
 
 test_config_file = """\
 Host *
@@ -58,17 +59,7 @@ BGQ3GQ/Fc7SX6gkpXkwcZryoi4kNFhHu5LvHcZPdxXV1D+uTMfGS1eyd2Yz/DoNWXNAl8TI0cAsW\
 from paramiko import *
 
 
-class UtilTest (unittest.TestCase):
+class UtilTest(ParamikoTest):
-
-    assertTrue = unittest.TestCase.failUnless   # for Python 2.3 and below
-    assertFalse = unittest.TestCase.failIf      # for Python 2.3 and below
-
-    def setUp(self):
-        pass
-
-    def tearDown(self):
-        pass
-    
     def test_1_import(self):
         """
         verify that all the classes can be imported from paramiko.

tests/util.py

@@ -0,0 +1,10 @@
+import unittest
+
+
+class ParamikoTest(unittest.TestCase):
+    # for Python 2.3 and below
+    if not hasattr(unittest.TestCase, 'assertTrue'):
+        assertTrue = unittest.TestCase.failUnless
+    if not hasattr(unittest.TestCase, 'assertFalse'):
+        assertFalse = unittest.TestCase.failIf
+